Skip to content

fix /permissive- flag causing a compile error on clang for windows #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 2 commits into from
Mar 9, 2025
+6 −2
Merged

fix /permissive- flag causing a compile error on clang for windows #305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
810a750
fix /permissive- flag casuing a compile error on clang for windows
dankmeme01 Feb 26, 2025
b7b17e6
improve check for /permissive- flag
dankmeme01 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve check for /permissive- flag
  • Loading branch information
@dankmeme01
dankmeme01 committed Feb 26, 2025
commit b7b17e6cac5ba03408293a3b9b03eacb918422e8
13 changes: 7 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,14 @@ if(FASTFLOAT_SANITIZE)
target_link_libraries(fast_float INTERFACE -fuse-ld=gold)
endif()
endif()
if(MSVC_VERSION GREATER 1910)
# /permissive- will only work on MSVC or clang-cl, clang will not accept it.
if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
target_compile_options(fast_float INTERFACE /permissive-)
endif()
endif()

include(CheckCXXCompilerFlag)
unset(FASTFLOAT_COMPILER_SUPPORTS_PERMISSIVE)
CHECK_CXX_COMPILER_FLAG(/permissive- FASTFLOAT_COMPILER_SUPPORTS_PERMISSIVE)

if(FASTFLOAT_COMPILER_SUPPORTS_PERMISSIVE)
target_compile_options(fast_float INTERFACE /permissive-)
endif()

if(FASTFLOAT_INSTALL)
include(CMakePackageConfigHelpers)
Expand Down