Skip to content

Add allow_leading_plus and skip_white_space in chars_format #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 11 commits into from
Nov 21, 2024
Merged

Add allow_leading_plus and skip_white_space in chars_format #280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0bbba96
move from feature macros to format flags
dalle Nov 20, 2024
48252a6
check feature macros in once place
dalle Nov 20, 2024
d80be1a
RFC 8259 obsoletes RFC 7159
dalle Nov 20, 2024
cd28b56
update rcppfastfloat_test
dalle Nov 20, 2024
43a428d
remove feature macro from tests
dalle Nov 20, 2024
1e188d9
add missing json test
dalle Nov 20, 2024
3e26cf4
add failing test for wide chars
dalle Nov 20, 2024
7ff885d
fix for is_space for wchar_t and larger char types
dalle Nov 20, 2024
50ee38a
fix for fastfloat_strncasecmp for wchar_t and larger char types
dalle Nov 20, 2024
dead62d
disable test if fast-math is enabled
dalle Nov 20, 2024
4ed0177
update and reformat README.md
dalle Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for is_space for wchar_t and larger char types
  • Loading branch information
@dalle
dalle committed Nov 20, 2024
commit 7ff885d45ca93ce16d7d665094707b1a5df60652
4 changes: 3 additions & 1 deletion include/fast_float/float_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,9 @@ template <typename T> constexpr bool space_lut<T>::value[];

#endif

inline constexpr bool is_space(uint8_t c) { return space_lut<>::value[c]; }
template <typename UC> constexpr bool is_space(UC c) {
return c < 256 && space_lut<>::value[uint8_t(c)];
}

template <typename UC> static constexpr uint64_t int_cmp_zeros() {
static_assert((sizeof(UC) == 1) || (sizeof(UC) == 2) || (sizeof(UC) == 4),
Expand Down
4 changes: 2 additions & 2 deletions include/fast_float/parse_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ from_chars_float_advanced(UC const *first, UC const *last, T &value,

from_chars_result_t<UC> answer;
if (uint64_t(fmt & chars_format::skip_white_space)) {
while ((first != last) && fast_float::is_space(uint8_t(*first))) {
while ((first != last) && fast_float::is_space(*first)) {
first++;
}
}
Expand Down Expand Up @@ -346,7 +346,7 @@ from_chars_int_advanced(UC const *first, UC const *last, T &value,

from_chars_result_t<UC> answer;
if (uint64_t(fmt & chars_format::skip_white_space)) {
while ((first != last) && fast_float::is_space(uint8_t(*first))) {
while ((first != last) && fast_float::is_space(*first)) {
first++;
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/rcppfastfloat_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ bool eddelbuettel() {
// check that there is no content left
for (const char *leftover = answer.ptr;
leftover != input.data() + input.size(); leftover++) {
if (!fast_float::is_space(uint8_t(*leftover))) {
if (!fast_float::is_space(*leftover)) {
non_space_trailing_content = true;
break;
}
Expand Down