Skip to content

fix: set relationships when model_validate receives a dict #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latent-9 wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −1
Open

fix: set relationships when model_validate receives a dict #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78cdade
fix(_compat): set relationships when model_validate receives a dict
latent-9 Aug 11, 2026
d549b10
🎨 Auto format
pre-commit-ci-lite[bot] Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sqlmodel/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,13 @@ def sqlmodel_validate(
# Get and set any relationship objects
if is_table_model_class(cls):
for key in new_obj.__sqlmodel_relationships__:
value = getattr(use_obj, key, Undefined)
# use_obj can be a dict (the input obj, or the merged obj when
# update is passed), so read relationships accordingly instead of
# assuming attribute access.
if isinstance(use_obj, dict):
value = use_obj.get(key, Undefined)
else:
value = getattr(use_obj, key, Undefined)
if value is not Undefined:
setattr(new_obj, key, value)
return new_obj
Expand Down
25 changes: 25 additions & 0 deletions tests/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,28 @@ def reject_none(cls, v):

with pytest.raises(ValidationError):
Hero.model_validate({"name": None, "age": 25})


def test_validate_dict_sets_relationship(clear_sqlmodel):
"""A relationship passed inside the dict given to model_validate must be
set, consistent with the constructor and with model_validate(object)."""

from sqlmodel import Field, Relationship

class Team(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
heroes: list["Hero"] = Relationship(back_populates="team")

class Hero(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
team_id: int | None = Field(default=None, foreign_key="team.id")
team: Team | None = Relationship(back_populates="heroes")

team = Team(name="Avengers")

# constructor already works; model_validate must match it
assert Hero(name="IronMan", team=team).team is team
assert Hero.model_validate({"name": "Thor", "team": team}).team is team
assert Hero.model_validate({"name": "Hulk"}, update={"team": team}).team is team
Loading