🐛 Fix status_code being ignored for SSE and JSONL streaming endpoints#15937
Open
SAURABHSALVE wants to merge 1 commit into
Open
🐛 Fix status_code being ignored for SSE and JSONL streaming endpoints#15937SAURABHSALVE wants to merge 1 commit into
SAURABHSALVE wants to merge 1 commit into
Conversation
d41bce7 to
8c2b6c8
Compare
Author
|
Hi maintainers, all code/test checks are passing now. The only failing required check is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSE and JSONL streaming endpoints ignore the
status_codedeclared on the path operation and any status code set by a dependency on theResponseparameter, always returning 200 while the generated OpenAPI documents the declared code. That makes the schema contradict the actual behavior.Raw streaming responses (
response_class=StreamingResponse) already handle both declared and dependency-set status codes via_build_response_args().This PR applies the same
_build_response_args()path to the SSE and JSONL branches. Default behavior is unchanged because the dependency solver's temporary response starts withstatus_code = None, so no status is injected unless the user declared or set one.Adds
tests/test_stream_status_code.pycovering: