Skip to content

Fix typos in docs and source code, fix status_code priority in _build_response_args#15699

Open
sadreammm wants to merge 2 commits into
fastapi:masterfrom
sadreammm:fix/typos-docs-and-source
Open

Fix typos in docs and source code, fix status_code priority in _build_response_args#15699
sadreammm wants to merge 2 commits into
fastapi:masterfrom
sadreammm:fix/typos-docs-and-source

Conversation

@sadreammm
Copy link
Copy Markdown

Bug fix:

  • routing.py: The _build_response_args function was unconditionally overwriting the explicit status_code parameter with the response class default. Fixed with if/elif so the explicit parameter takes priority.

Typos (8 fixes across docs + source):

  • "doesn't known" -> "doesn't know" (https.md)
  • Missing "they" (project-generation.md)
  • "Environment Variable" -> "Environment Variables" (environment-variables.md)
  • "an undefined behavior" -> "undefined behavior" (body.md)
  • Two broken Markdown links missing ) (param_functions.py)
  • Double space "HTML that" (docs.py)
  • Truncated comment "satisfy ty" (datastructures.py)
  • Four backticks -> three in two docstrings (oauth2.py)

Test cleanup:

  • Removed two leftover print() debug statements

@sadreammm sadreammm marked this pull request as draft June 6, 2026 15:52
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 6, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing sadreammm:fix/typos-docs-and-source (1d908dc) with master (782476e)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (5cdf820) during the generation of this report, so 782476e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

@sadreammm sadreammm marked this pull request as ready for review June 6, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant