Skip to content

Cmake tweaks #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joankaradimov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cmake tweaks #110

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd04b4f
Correctly pass warning level to the compiler
joankaradimov Mar 15, 2022
7508655
Only compile the test suite if TESTSUITE is defined
joankaradimov Mar 15, 2022
9849b9f
Allow the examples to be disabled in the compilation
joankaradimov Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correctly pass warning level to the compiler 
Use `add_compile_options ("-W4")` instead of `add_definitions ("-W4")` since
the latter passes a `-W4` argument to `rc.exe` which results in this error:

  fatal error RC1106: invalid option: -4

The same is done for non-MSVC compilers for consistency and to avoid similar
problems.
  • Loading branch information
@joankaradimov
joankaradimov committed Mar 15, 2022
commit cd04b4f903f3d26a10ef12195a7e422e6ea27c6e
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ if (NOT MSVC)
endif ()

if (NOT MSVC)
add_definitions ("-Wall")
add_compile_options ("-Wall")
else ()
# Show level 4 warnings.
add_definitions ("-W4")
add_compile_options ("-W4")
endif ()

option(UNICODE "Compile with UNICODE support" OFF)
Expand Down