Skip to content

set method is better than direct change of the attribute #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vartagg wants to merge 2 commits into from
Closed

set method is better than direct change of the attribute #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e0307
`set` method is better than direct change of the attribute
vartagg Dec 2, 2014
b9b5ea3
Rename adapted method passing to adapter for avoid confusion about id…
vartagg Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,35 @@

"""http://ginstrom.com/scribbles/2008/11/06/generic-adapter-class-in-python/"""

import os

class Dog(object):
def __init__(self):
self.name = "Dog"

def bark(self):
return "woof!"


class Cat(object):
def __init__(self):
self.name = "Cat"

def meow(self):
return "meow!"


class Human(object):
def __init__(self):
self.name = "Human"

def speak(self):
return "'hello'"


class Car(object):
def __init__(self):
self.name = "Car"

def make_noise(self, octane_level):
return "vroom{0}".format("!" * octane_level)

Expand All @@ -37,18 +42,18 @@ class Adapter(object):
Adapts an object by replacing methods.
Usage:
dog = Dog
dog = Adapter(dog, dict(make_noise=dog.bark))
dog = Adapter(dog, dict(emit_sound=dog.bark))

>>> objects = []
>>> dog = Dog()
>>> objects.append(Adapter(dog, dict(make_noise=dog.bark)))
>>> objects.append(Adapter(dog, dict(emit_sound=dog.bark)))
>>> cat = Cat()
>>> objects.append(Adapter(cat, dict(make_noise=cat.meow)))
>>> objects.append(Adapter(cat, dict(emit_sound=cat.meow)))
>>> human = Human()
>>> objects.append(Adapter(human, dict(make_noise=human.speak)))
>>> objects.append(Adapter(human, dict(emit_sound=human.speak)))
>>> car = Car()
>>> car_noise = lambda: car.make_noise(3)
>>> objects.append(Adapter(car, dict(make_noise=car_noise)))
>>> objects.append(Adapter(car, dict(emit_sound=car_noise)))

>>> for obj in objects:
... print('A {} goes {}'.format(obj.name, obj.make_noise()))
Expand All @@ -58,8 +63,8 @@ class Adapter(object):
A Car goes vroom!!!
"""

def __init__(self, obj, adapted_methods):
"""We set the adapted methods in the object's dict"""
def __init__(self, obj, **adapted_methods):
"""We set the adapted methods in the kwargs"""
self.obj = obj
self.__dict__.update(adapted_methods)

Expand All @@ -71,16 +76,16 @@ def __getattr__(self, attr):
def main():
objects = []
dog = Dog()
objects.append(Adapter(dog, dict(make_noise=dog.bark)))
objects.append(Adapter(dog, emit_sound=dog.bark))
cat = Cat()
objects.append(Adapter(cat, dict(make_noise=cat.meow)))
objects.append(Adapter(cat, emit_sound=cat.meow))
human = Human()
objects.append(Adapter(human, dict(make_noise=human.speak)))
objects.append(Adapter(human, emit_sound=human.speak))
car = Car()
objects.append(Adapter(car, dict(make_noise=lambda: car.make_noise(3))))
objects.append(Adapter(car, emit_sound=lambda: car.make_noise(3)))

for obj in objects:
print("A {0} goes {1}".format(obj.name, obj.make_noise()))
print("A {0} goes {1}".format(obj.name, obj.emit_sound()))


if __name__ == "__main__":
Expand Down
17 changes: 10 additions & 7 deletions builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@
class Director(object):

def __init__(self):
self.builder = None
self._builder = None

def set_builder(self, builder):
self._builder = builder

def construct_building(self):
self.builder.new_building()
self.builder.build_floor()
self.builder.build_size()
self._builder.new_building()
self._builder.build_floor()
self._builder.build_size()

def get_building(self):
return self.builder.building
return self._builder.building


# Abstract Builder
Expand Down Expand Up @@ -65,11 +68,11 @@ def __repr__(self):
# Client
if __name__ == "__main__":
director = Director()
director.builder = BuilderHouse()
director.set_builder(BuilderHouse())
director.construct_building()
building = director.get_building()
print(building)
director.builder = BuilderFlat()
director.set_builder(BuilderFlat())
director.construct_building()
building = director.get_building()
print(building)
Expand Down