Separate version specific scripts#287
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 70.21% 66.85% -3.36%
==========================================
Files 56 58 +2
Lines 2058 2091 +33
==========================================
- Hits 1445 1398 -47
- Misses 613 693 +80
Continue to review full report at Codecov.
|
This was referenced Mar 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@faif
This PR is related to our discussion in #208
#208 (comment)
There are 4 scripts with metaclasses (chain_of_responsibility, registry, blackboard, flyweight).
I modified 2/4 here to get your feedback. If you are ok with these changes - please let me know. I'll finish work in this or separate PR.