Skip to content

Test outputs starting with visitor and strategy#262

Merged
faif merged 2 commits into
faif:masterfrom
gyermolenko:test_visitor_outputs
Jan 13, 2019
Merged

Test outputs starting with visitor and strategy#262
faif merged 2 commits into
faif:masterfrom
gyermolenko:test_visitor_outputs

Conversation

@gyermolenko
Copy link
Copy Markdown
Contributor

  • append_output.sh script

  • updated strategy.py and visitor.py according to new scructure

def main():
    ...

if __name__ == "__main__":
   main()

OUTPUT = """
foo
bar
"""
  • added test_outputs.py with generic test which should fit all scripts of the new structure

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 12, 2019

Codecov Report

Merging #262 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   97.65%   97.67%   +0.01%     
==========================================
  Files          61       61              
  Lines        2221     2238      +17     
==========================================
+ Hits         2169     2186      +17     
  Misses         52       52
Impacted Files Coverage Δ
behavioral/visitor.py 100% <100%> (ø) ⬆️
behavioral/strategy.py 100% <100%> (ø) ⬆️
tests/test_outputs.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d363b...b88f43d. Read the comment docs.

@gyermolenko
Copy link
Copy Markdown
Contributor Author

so I just found out from CI for py2 that contextlib.redirect_stdout is not available in py2 (only since 3.4).
Workarounds exist, but at the moment I don't see any problem performing test_outputs for py3 only.

@faif faif merged commit 040f0d0 into faif:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants