Skip to content

Refactor Strategy#257

Merged
faif merged 3 commits into
faif:masterfrom
gyermolenko:refactor_strategy
Jan 11, 2019
Merged

Refactor Strategy#257
faif merged 3 commits into
faif:masterfrom
gyermolenko:refactor_strategy

Conversation

@gyermolenko
Copy link
Copy Markdown
Contributor

  • I dont think we should use types.MethodType(func, self) on a day to day basis.
  • I also wanted to see something more specific than "StrategyExample", "execute", "execute_replacement1/2"..

@gyermolenko
Copy link
Copy Markdown
Contributor Author

gyermolenko commented Jan 4, 2019

ok. I can see that tests/test_strategy.py has failed but it is only because it has hardcoded outputs from previous version.
I need to clatify something before fix (linking suggestion from #258 )

@gyermolenko
Copy link
Copy Markdown
Contributor Author

fixed test as it is. working on testing outputs idea separately

@faif faif merged commit 74d363b into faif:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants