ENH+BF: fix up of some tests/docs to pass with python2.7, testing on travis, consistent shebanging, by yarikoptic · Pull Request #144 · faif/python-patterns

yarikoptic · 2016-05-17T16:12:18Z

I really loved the idea and the collection so decided to contribute a bit ;)

https://travis-ci.org/yarikoptic/python-patterns/builds/130877280
should eventually reflect current state of things -- either tests pass as is or more things to be done

Please enable travis for your project @faif -- it is easy, just go to http://travis-ci.org, authenticate through github, click toggle for this repository

I have already complained in #143 about necessity to have clear copyright/license statement(s) so this code could e.g. be actually used/redistributed etc. Ideally the most permissive license (BSD-2 or -3 or MIT) would be the best fit.

Also would be nice to make all code PEP8 compliant. I have added call to flake8 in travis.yml but ignoring its failure atm. Didn't want to introduce big "stylistic" changes without "go ahead"

…n__"

…unction from future for chaining_method.py

yarikoptic · 2016-05-17T16:26:29Z

ok -- with a small tune up (could not do || : for some reason), now all splendid: https://travis-ci.org/yarikoptic/python-patterns/builds/130880031

also here is coverage report from https://codecov.io/gh/yarikoptic/python-patterns (also enable for your repo, and then can add a badge or two to your README etc)

fkromer · 2016-05-17T18:00:14Z

I did not get why lines 81, 61 and 91 in https://codecov.io/gh/yarikoptic/python-patterns/src/ef3dbe3b17b10f9926607f98fa10b1913c61476f/test_hsm.py are not covered...

yarikoptic · 2016-05-17T18:28:04Z

Pushed more fixes and trying to enhance testing by actually running all of the scripts. It required also fixing 3-tier.py by reverting 69b507b -- descriptors must be bound to classes, not to instances, thus that change broke the "pythonish" idea completely. Could be redone without relying on Python descriptors at the instance level

…tment to UI and Business logic for injecting dependencies" This reverts commit 69b507b.

… tool

yarikoptic · 2016-05-17T19:13:16Z

woohoo -- tests pass again (although I have dropped pypy* for now, was getting stuck), and coverage is whooping 93%: see https://codecov.io/gh/yarikoptic/python-patterns on what to improve. You can easily get 100% with little effort!

yarikoptic · 2016-05-17T19:21:00Z

On Tue, 17 May 2016, thinwybk wrote:

I did not get why lines 81, 61 and 91 in
https://codecov.io/gh/yarikoptic/python-patterns/src/ef3dbe3b17b10f9926607f98fa10b1913c61476f/test_hsm.py
are not covered...

ain't auto coverage great?! ;)

my guess, is that since it is assertRaises, is that previous lines cause
the exception, so it leaves the context manager scope before executing
them. Fix should be easy (if legit) to just dedent those lines out of
the context manager scope ;)

Yaroslav O. Halchenko
Center for Open Neuroscience http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

yarikoptic · 2016-05-17T19:27:04Z

On Tue, 17 May 2016, Yaroslav Halchenko wrote:

On Tue, 17 May 2016, thinwybk wrote:

I did not get why lines 81, 61 and 91 in
https://codecov.io/gh/yarikoptic/python-patterns/src/ef3dbe3b17b10f9926607f98fa10b1913c61476f/test_hsm.py
are not covered...

ain't auto coverage great?! ;)

my guess, is that since it is assertRaises, is that previous lines cause
the exception, so it leaves the context manager scope before executing
them. Fix should be easy (if legit) to just dedent those lines out of
the context manager scope ;)

ok -- did that for that file... there might be more...
also added some pragma no cover's for points which it is ok to expect no
coverage

Yaroslav O. Halchenko
Center for Open Neuroscience http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

yarikoptic · 2016-05-17T19:52:33Z

ok -- test_hsm is now at 100% ;) overall:

fkromer · 2016-05-17T20:11:02Z

Thanks a lot :)

fkromer · 2016-05-17T20:15:42Z

Could you merge https://github.com/fkromer/python-patterns/tree/test_proxy (#139) into your fork to make sure these tests are still running ;)

* pr-139: change: refactor (work -> talk) change: refactoring self->cls

yarikoptic · 2016-05-17T20:49:41Z

On Tue, 17 May 2016, thinwybk wrote:

Could you merge https://github.com/fkromer/python-patterns/tree/test_proxy
(#139) into your fork to make sure these tests are still running ;)

heh -- only for you and only today... merged, fixed it up the
test although don't like what I have done and the test logic/duplication
in general. but better some test than no tests! ;)

Yaroslav O. Halchenko
Center for Open Neuroscience http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

…version specific import of StringIO (breaks on 2.x with io.StringIO)

fkromer · 2016-05-17T21:33:03Z

Thanks! That's just how it is (right now). :)

faif · 2016-05-18T16:33:37Z

Hi,

Thanks for your contributions. Sorry for not taking any actions yet but I'm ill. I will check everything after recovering.

Kind regards,
Sakis

On 17 Μαΐ 2016, at 23:33, thinwybk notifications@github.com wrote:

Thanks! That's just how it is (right now). :)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

yarikoptic · 2016-05-18T17:19:15Z

Thanks for your contributions. Sorry for not taking any actions yet but
I'm ill. I will check everything after recovering.

sure -- no rush. Get better!

fkromer and others added 9 commits April 25, 2016 20:25

change: refactoring self->cls

4e70c41

change: refactor (work -> talk)

070c2cf

merge with faif/master

ee428bb

BF(PY2): use mock module if no unittest.mock is available

b4993f3

BF: test_strategy -- use OS specific os.linesep + shebang

74fc693

ENH: have shebangs consistently in every file with __name__ == "__mai…

ebbacb4

…n__"

BF: fixing docstring to pass doctest in adapter.py and import print_f…

a0d3711

…unction from future for chaining_method.py

rudimentary .travis.yml which also ignores flake8 failures for now

29dc431

for uniformity -- no exec bit on delegation_pattern.py

ef3dbe3

yarikoptic force-pushed the master branch from 6580f76 to ef3dbe3 Compare May 17, 2016 16:17

yarikoptic referenced this pull request May 17, 2016

Adjustment to UI and Business logic for injecting dependencies

69b507b

yarikoptic added 6 commits May 17, 2016 14:31

BF: minor typo unit[t]est

8cc5924

BF/ENH: assure that foo.txt exists and no conflicts for demonstration

c5ce565

BF: descriptors must be bound to class, not instance -- Revert "Adjus…

b36e630

…tment to UI and Business logic for injecting dependencies" This reverts commit 69b507b.

ENH: reduce sleep to 0.1 for consistency

187c3bc

ENH(TST): actually run all the scripts while testing on travis

6b2d7d1

BF: moved running all the scripts via coverage into a separate helper…

63b9759

… tool

yarikoptic force-pushed the master branch from 60c6567 to 63b9759 Compare May 17, 2016 18:37

BF(PY3): use next() instead of .next() (PY3 only)

1e82c2d

yarikoptic mentioned this pull request May 17, 2016

When flyweight.py is run as skript it raises an error #117

Closed

yarikoptic added 2 commits May 17, 2016 15:05

TEMP workaround: flyweight is not compatible with Python3

9a65401

BF(TEMP): Disabled pypy for now -- gets stuck

e2a12b4

yarikoptic force-pushed the master branch from b23274e to e2a12b4 Compare May 17, 2016 19:06

yarikoptic added 2 commits May 17, 2016 15:25

ENH: pragma: no cover for conditioning of mock imports

8edfdcd

BF: dedent few assertions out of with assertRaises cm

2893a03

Merge branch 'pr-139'

b3d6693

* pr-139: change: refactor (work -> talk) change: refactoring self->cls

BF(TST): fixing test_proxy for recent decrease of sleep, but also py …

126bbd9

…version specific import of StringIO (breaks on 2.x with io.StringIO)

yarikoptic force-pushed the master branch from 8356793 to 126bbd9 Compare May 17, 2016 21:00

faif merged commit b54cad9 into faif:master May 21, 2016

Conversation

yarikoptic commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

fkromer commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

fkromer commented May 17, 2016

Uh oh!

fkromer commented May 17, 2016

Uh oh!

yarikoptic commented May 17, 2016

Uh oh!

fkromer commented May 17, 2016

Uh oh!

faif commented May 18, 2016

Uh oh!

yarikoptic commented May 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants