Skip to content

chore(ci): explicitly disable setup-node cache in release and supply-chain workflows (AI-assisted) - #12479

Merged
slorber merged 1 commit into
mainfrom
claude/github-actions-node-cache-security-eb54a8
Sep 24, 2026
Merged

slorber merged 1 commit into
mainfrom
claude/github-actions-node-cache-security-eb54a8

Conversation

@slorber

@slorber slorber commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Audit of our actions/setup-node caching against v7.0.0 and its cache poisoning recommendations (actions/setup-node#1567).

Current state is safe: no pull_request_target / workflow_run / issue_comment triggers, PR caches are scoped to their PR ref, and release workflows (publish.yml, continuous-releases.yml) don't restore any cache. setup-node auto-caching only triggers for npm (we use pnpm), and pnpm/action-setup caching is off by default.

This PR adds an explicit package-manager-cache: false to the no-cache workflows (publish, continuous releases, supply chain security) as defense-in-depth, so caching can't silently turn on if auto-detection behavior or our package manager changes.

(AI-assisted)

Test Plan

CI

Test links

Deploy preview: https://deploy-preview-12479--docusaurus-2.netlify.app/

Related issues/PRs

🤖 Generated with Claude Code

…chain workflows (AI-assisted)

Follows actions/setup-node v7 guidance (actions/setup-node#1567) to set
`package-manager-cache: false` in privileged workflows to mitigate cache poisoning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@slorber
slorber requested a review from Josh-Cena as a code owner September 24, 2026 10:13
@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Sep 24, 2026
@netlify

netlify Bot commented Sep 24, 2026

Copy link
Copy Markdown

✅ [V2]

Name Link
🔨 Latest commit 96a71fc
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6ab4f7bc70e510000802d2bc
😎 Deploy Preview https://deploy-preview-12479--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label Sep 24, 2026
@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 58 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 56 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 69 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 66 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 66 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 66 🟢 100 🟢 100 🟠 86 Report

@slorber
slorber merged commit be0589c into main Sep 24, 2026
18 checks passed
@slorber
slorber deleted the claude/github-actions-node-cache-security-eb54a8 branch September 24, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant