replace on-finished with native stream.finished for request handling#598
Closed
bjohansebas wants to merge 1 commit intoexpressjs:masterfrom
Closed
replace on-finished with native stream.finished for request handling#598bjohansebas wants to merge 1 commit intoexpressjs:masterfrom
on-finished with native stream.finished for request handling#598bjohansebas wants to merge 1 commit intoexpressjs:masterfrom
Conversation
bjohansebas
commented
Apr 12, 2025
| if (req.writableEnded || req.writabledFinished) { | ||
| callback(null) | ||
| } else { | ||
| onFinished(req, callback) |
Member
Author
There was a problem hiding this comment.
I've opened an issue in Node to fix the tests that are failing due to this change.
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
d6cc38d to
4f05a16
Compare
Member
Author
|
on-finished stays, since nodejs/node#57844 is a bug it can't be integrated, and isFinished checks too many things to keep it here, so let's stick with that package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm investigating how to stop using
on-finishedhere and handle it directly with the properties that Node.js provides. I don't know if it's possible or if there are any bugs.It's likely that changes will need to be made in raw-body, as it handles a large part of this module's logic.