feat(exact): validate oneOf chains#1282
Draft
fedeci wants to merge 2 commits into
Draft
Conversation
fedeci
commented
Feb 22, 2024
Comment on lines
+45
to
+49
| pushSubcontext(...contexts: ReadonlyContext[]) { | ||
| this.subcontexts.push(...contexts); | ||
| return this; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Before merging this I want experiment with inheritance of contexts to see if I can create separate contexts for each of the middlewares we provide. All of them would conform to a shared interface, so that some methods are easily callable without type casting.
| return; | ||
| (internalReq[contextsKey] || []) | ||
| .flatMap(context => { | ||
| // TODO: This does not work for nested oneOf |
Member
Author
There was a problem hiding this comment.
This is something I feel that inherited contexts may help to achieve
Comment on lines
-13
to
-18
| import { ContextItem } from '../context-items'; | ||
| import { runAllChains } from '../utils'; | ||
|
|
||
| // A dummy context item that gets added to surrogate contexts just to make them run | ||
| const dummyItem: ContextItem = { async run() {} }; | ||
|
|
Member
Author
There was a problem hiding this comment.
Was this useful? Removing it did not make any test to fail.
|
Will it be implemented? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1269
To-do list