Repository navigation
Conversation
The CLI smoke steps in tests.yml were gated on python_version == '3.9'. d01a180 removed 3.9 from the build matrix, so those nine steps have been skipped on every leg since. Point the guard at 3.10 (still in the matrix), matching the previous bump in explosion#12409. Fixes explosion#14049
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI smoke steps in
.github/workflows/tests.yml(download, info, convert, debug config/data, train, assemble, plus the #11713 load-warning check) were gated onmatrix.python_version == '3.9'. Commit d01a180 removed 3.9 from the build matrix, so those nine steps have been skipped on every leg since.This PR points the guard at
'3.10', which is still in the matrix — the same bump pattern as #12409 when the floor moved from 3.8 → 3.9.Reporter @glaziermag already verified the nine steps pass on ubuntu/windows/macOS with this change on their fork; this PR is only the literal swap.
Fixes #14049
Checklist
(No new unit test — this restores existing CI coverage that was accidentally disabled.)