Skip to content

atbash-cipher: add parameters to exercise placeholder - #706

Merged
ilya-khadykin merged 2 commits into
exercism:masterfrom
parinporecha:atbash-cipher
Oct 4, 2017
Merged

atbash-cipher: add parameters to exercise placeholder#706
ilya-khadykin merged 2 commits into
exercism:masterfrom
parinporecha:atbash-cipher

Conversation

@parinporecha

@parinporecha parinporecha commented Oct 4, 2017 •
edited by ilya-khadykin
Loading

Copy link
Copy Markdown
Contributor

Fixes #542

@parinporecha parinporecha mentioned this pull request Oct 4, 2017
Closed
ilya-khadykin
ilya-khadykin approved these changes Oct 4, 2017
View reviewed changes

@ilya-khadykin ilya-khadykin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Comment thread exercises/atbash-cipher/atbash_cipher.py Outdated
@@ -1,6 +1,6 @@
def encode(string):
def encode(plain):

@ilya-khadykin ilya-khadykin Oct 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me plain_text and ciphered_text looks a bit better.
But your suggestion is also Ok

@parinporecha parinporecha Oct 4, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-a-Ge Your suggestion is better. I've changed them to plain_text and ciphered_text

@ilya-khadykin
ilya-khadykin merged commit c7df48e into exercism:master Oct 4, 2017
@ilya-khadykin

ilya-khadykin commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

@parinporecha, thanks for your contribution!

It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃

Please also note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
It makes our work much easier. I hope this hint will help you to make your future PRs a bit better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ilya-khadykin ilya-khadykin ilya-khadykin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parinporecha @ilya-khadykin