Pig Latin - Added Parameters to Placeholders#592
Conversation
|
@Sukhj1nder congrats on your first merged PR! I hope it won't be the last 😀 I've corrected your commit message, here is a good guide of how to write good commit messages https://chris.beams.io/posts/git-commit/#seven-rules Please also note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge. |
|
@m-a-ge i'm very new to contributing to open-source project, this is actually my first contribution ever, it says that i can delete the branch. Should I? |
|
@Sukhj1nder yeah, sure. It's an awesome feature of Github, it just removes the branch you've used for this PR ( |
Added Parameters to the Pig Latin file in the function
translateThis resolves the issue #592.
TODO: Pig Latin - Ticked on #509
Fixes #609