Skip to content

Fixed small typo in introduction.md#3621

Merged
BethanyG merged 4 commits into
exercism:mainfrom
zakweb3:patch-1
Feb 6, 2024
Merged

Fixed small typo in introduction.md#3621
BethanyG merged 4 commits into
exercism:mainfrom
zakweb3:patch-1

Conversation

@zakweb3
Copy link
Copy Markdown
Contributor

@zakweb3 zakweb3 commented Feb 6, 2024

Fixed small typo in line 65 replaced : with =

Fixed small typo in line 65 replaced : with =
@github-actions

This comment was marked as resolved.

@github-actions github-actions Bot closed this Feb 6, 2024
@BethanyG
Copy link
Copy Markdown
Member

BethanyG commented Feb 6, 2024

Hi @zakweb3 👋🏽

Thanks for filing this PR (and for so thoroughly reading the docs! 😄).

You don't know this, but this introduction.md pulls from the tuples concept doc, so that doc likely has the same mistake. Could you check that, and if it needs correcting, submit it as well?

Once that's sorted, I will happily merge.

Many thanks. 🚀

@BethanyG BethanyG reopened this Feb 6, 2024
Copy link
Copy Markdown
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my prior comment, please review the concept about.md to see if a change is required there as well. Thanks!

@zakweb3
Copy link
Copy Markdown
Contributor Author

zakweb3 commented Feb 6, 2024

I made the same change (replaced : with =) in line 101 in the about.md
#3623
Thank you for considering my PR.

@BethanyG
Copy link
Copy Markdown
Member

BethanyG commented Feb 6, 2024

@sudhackar -- please don't review PRs in this repo unless you are on the maintainer team/have reviewer permissions. It's confusing to contributors and creates noise for maintainers. Thanks.

@zakweb3 -- I meant for the requested change to be included in this PR, not in a separate one. Could you please combine the two changes here and close the other PR? Many thanks!

Replaced : with = in line 101
@zakweb3
Copy link
Copy Markdown
Contributor Author

zakweb3 commented Feb 6, 2024

I thought you wanted to update just the 'about.md'
I was a bit confused by

You don't know this, but this introduction.md pulls from the about.md

Now I did the modification on both files and deleted the other patch.
I hope that works for you!

@BethanyG
Copy link
Copy Markdown
Member

BethanyG commented Feb 6, 2024

I thought you wanted to update just the 'about.md'
I was a bit confused by

> You don't know this, but this introduction.md pulls from the about.md

Apologies for the confusing wording. 🙂

Now I did the modification on both files and deleted the other patch.
I hope that works for you!

It does! As soon as CI passes, I will review and merge!

Copy link
Copy Markdown
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Looks good! 🚀

Comment thread concepts/tuples/about.md Outdated
Comment thread concepts/tuples/about.md Outdated
@BethanyG BethanyG merged commit 67b3757 into exercism:main Feb 6, 2024
petrem pushed a commit to petrem/exercism--python that referenced this pull request Dec 22, 2025
* Update introduction.md

Fixed small typo in line 65 replaced : with =

* Update about.md

Replaced : with = in line 101

* Apply suggestions from code review

* Update concepts/tuples/about.md

---------

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants