Skip to content

[Pythagorean Triplet]: Add Approaches#3582

Merged
BethanyG merged 4 commits into
exercism:mainfrom
colinleach:approach-pythag-triplet
Jan 20, 2024
Merged

[Pythagorean Triplet]: Add Approaches#3582
BethanyG merged 4 commits into
exercism:mainfrom
colinleach:approach-pythag-triplet

Conversation

@colinleach
Copy link
Copy Markdown
Contributor

I'm getting lost in this. There are lots of files and quite a bit of repetition, so I'm not always sure what goes where.

I think most of the content is now in there somewhere. I'm submitting it for discussion, in the expectation that we may at least want to move things around.

@BethanyG : there's a placeholder for you in linear/content.md

You may wish to comment on your own submission!

colinleach and others added 4 commits January 3, 2024 16:17
Sorry, I committed this to the wrong branch. Embarrassingly amateurish!
Suggestions and edits.
Because we need to PR to a different repo, the `.svg` images have been removed, and the text adjusted.
@BethanyG
Copy link
Copy Markdown
Member

@colinleach -- per our discussion, I removed the svg graphs. Is there anything else you'd like to change before we merge this? Just let me know -- thanks!

@colinleach
Copy link
Copy Markdown
Contributor Author

No changes from me, at least at this stage. I reserve the right to change my mind when I see it live on Exercism - that can surface some hidden problems (as I discovered with r/reverse-string this morning).

@BethanyG
Copy link
Copy Markdown
Member

(as I discovered with r/reverse-string this morning).

uh oh! Hopefully, they got resolved quickly!

..and you can PR changes to this as needed! We also need to do dark/light versions of graphs at some point as well.

But if this looks good-ish, Ima gonna merge! 🎉

@BethanyG BethanyG merged commit 6f1fa93 into exercism:main Jan 20, 2024
@BethanyG BethanyG changed the title [Pythagorean Triplet]: Approaches Draft [Pythagorean Triplet]: Add Approaches Jan 20, 2024
petrem pushed a commit to petrem/exercism--python that referenced this pull request Dec 22, 2025
* [Pythagorean Triplet]: Approaches Draft

* [Leap]: Add `isleap` approach and improved benchmarks

* Delete exercises/practice/leap/.articles/performance/timeit_bar_plot.svg

Sorry, I committed this to the wrong branch. Embarrassingly amateurish!

* Suggestions, Edits, etc.

Suggestions and edits.
Because we need to PR to a different repo, the `.svg` images have been removed, and the text adjusted.

---------

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants