pangram: Add extra invalid pangram test case#331
Merged
Conversation
8 tasks
Member
|
This is a great find, thank you! I've added a note about this exercise so that we can add this test case to the other tracks as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reviewed a solution that was passing the tests by coincidence - they were performing an alphabetic string comparison between sets of letters, and the only non empty False test case was passing because the string ('a quick movement...') is alphabetically less than 'abcdef...'. It seemed like another test case would help here!
(See http://exercism.io/submissions/c6790b9a65fe4c08b865e5eb621fe94d)