Skip to content

Add prickle and smolder labels - #2636

Merged
J08K merged 1 commit into
exercism:mainfrom
J08K:J08K-New-Labels
Oct 7, 2021
Merged

Add prickle and smolder labels#2636
J08K merged 1 commit into
exercism:mainfrom
J08K:J08K-New-Labels

Conversation

@J08K

@J08K J08K commented Oct 7, 2021

Copy link
Copy Markdown
Member

These are some new labels:

  • prickle💢 - Label for issues that should be skipped by the auto-responder (to be added, almost done)
  • smolder🍲 - Label for issues or PRs that are a long-term idea, or lower priority for the track.

Discussed with: @BethanyG

@J08K
J08K requested a review from BethanyG October 7, 2021 21:55
BethanyG
BethanyG approved these changes Oct 7, 2021
View reviewed changes

@BethanyG BethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These make me happy. 😸 Thank you !

@J08K
J08K merged commit 5aede59 into exercism:main Oct 7, 2021
@SaschaMann

SaschaMann commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

For future reference: This file is not meant to be edited manually as indicated by the big warning on top:

python/.github/labels.yml

Lines 1 to 14 in 9772a9c

# --------------------------------------------------------------- #
# This is an auto-generated file - Do not manually edit this file #
# --------------------------------------------------------------- #
# This file is automatically generated by concatenating two files:
#
# 1. The Exercism-wide labels: defined in https://github.com/exercism/org-wide-files/blob/main/global-files/.github/labels.yml
# 2. The repository-specific labels: defined in the `.appends/.github/labels.yml` file within this repository.
#
# If any of these two files change, a pull request is automatically created containing a re-generated version of this file.
# Consequently, to change repository-specific labels you should update the `.appends/.github/labels.yml` file and _not_ this file.
#
# When the pull request has been merged, the GitHub labels will be automatically updated by the "Sync labels" workflow.
# This typically takes 5-10 minutes.

Doing so will lead to the labels being removed/overwritten eventually.

SaschaMann added a commit to SaschaMann/python that referenced this pull request Mar 8, 2022
@SaschaMann
Properly add prickle and smolder labels (fixes exercism#2636)
3d50784
@BethanyG

BethanyG commented Mar 9, 2022

Copy link
Copy Markdown
Member

@SaschaMann - Yup. The fact that these were to the main file slipped through the cracks originally. 🤦🏽‍♀️ . Thank you also for the PR that adds them to the addendum. 😄 I'll take a look when I have more of a chance tonight my time .... I may want to remove one of them after all.

@SaschaMann

SaschaMann commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

The fact that these were to the main file slipped through the cracks originally

At some point these should be codeowner'd to prevent this, I think. It's super easy to miss when reviewing.

BethanyG pushed a commit that referenced this pull request Mar 9, 2022
@SaschaMann @BethanyG
Properly add prickle and smolder labels (fixes #2636)
3a62377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethanyG BethanyG BethanyG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J08K @SaschaMann @BethanyG