Update CI test runner for v3#2284
Merged
Merged
Conversation
Contributor
cmccandless
commented
Jan 28, 2021
- Check for exemplar.py (>=v3), then example.py (<v3)
- See Convert example to exemplar v3#3086
- Use pathlib instead of os.path
- Use pathlib instead of os.path
Contributor
Author
|
Maintainer note: squash when merging |
BethanyG
reviewed
Jan 28, 2021
Member
There was a problem hiding this comment.
This looks good to me -- but with two questions:
- Is our
masterbranch going to be renamedmain? If so, we'll need to change the ref. - Should we hold this merge until after the "explosion"? We have some pending exercise PRs to finish up.
Otherwise, I think we are good to go 🌟
Contributor
Author
I've added main to target branches
I don't think that's necessary. If 'exemplar.py' is missing, it looks next for 'example.py', so this should be backwards compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.