Skip to content

alphametics: improve comments on extra-credit test #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yawpitch merged 4 commits into from
Nov 14, 2019
+12 −6
Merged

alphametics: improve comments on extra-credit test #2126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c4dab2
alphametics: improve comments on extra-credit test
cmccandless Nov 13, 2019
a274b3b
update template
cmccandless Nov 13, 2019
6e71059
Merge branch 'master' into cmccandless-patch-1
cmccandless Nov 13, 2019
2b5ccca
use cached condition
cmccandless Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions exercises/alphametics/.meta/template.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@
class {{ exercise | camel_case }}Test(unittest.TestCase):
{% for case in cases[0]["cases"] -%}
{% set description = case["description"] | to_snake -%}
{% set testdef = "def test_" ~ description ~ "(self):" -%}
{% set value = case["input"]["puzzle"] -%}
{% if value|length > 100 -%}
# Reason to skip this test at https://github.com/exercism/python/pull/1358
{% set long_test = value|length > 100 -%}
{% if long_test -%}
# See https://github.com/exercism/python/pull/1358
@unittest.skip("extra-credit")
{% endif %}
def test_{{ description }}(self):
{{ testdef }}
"""This test may take a long time to run. Please be patient when running it."""
{%- else %}
{{ testdef }}
{%- endif %}
{% set expected = case["expected"] -%}
{% if value|length > 100 -%}
{% if long_test -%}
{% for line in value | wrap_overlong(width=62) -%}
{% if loop.index == 1 -%}
puzzle = {{ line }}
Expand Down
3 changes: 2 additions & 1 deletion exercises/alphametics/alphametics_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ def test_puzzle_with_ten_letters(self):
},
)

# Reason to skip this test at https://github.com/exercism/python/pull/1358
# See https://github.com/exercism/python/pull/1358
@unittest.skip("extra-credit")
def test_puzzle_with_ten_letters_and_199_addends(self):
"""This test may take a long time to run. Please be patient when running it."""
puzzle = (
"THIS + A + FIRE + THEREFORE + FOR + ALL + HISTORIES + I + TELL"
"+ A + TALE + THAT + FALSIFIES + ITS + TITLE + TIS + A + LIE +"
Expand Down