rational-numbers add template#2080
Merged
cmccandless merged 12 commits intoOct 25, 2019
Merged
Conversation
cmccandless
suggested changes
Oct 22, 2019
Contributor
cmccandless
left a comment
There was a problem hiding this comment.
The reason that the non-arithmetic tests are not rendering is that the arithmetic tests are nested 3 levels deep, which you have accounted for, but the other tests are only 2 levels deep. Try this:
class {{ exercise | camel_case }}Test(unittest.TestCase):
{% for mathtypescases in cases %}
# Tests of type: {{ mathtypescases["description"] }}
{% if mathtypescases["description"] == 'Arithmetic' %}
{% for mathoperationcases in mathtypescases["cases"] %}
# {{ mathoperationcases["description"] }}
{% for case in mathoperationcases["cases"] %}
{{ test_case_arithmetic(case) }}
{% endfor %}
{% endfor %}
{% else %}
{% for case in mathtypescases["cases"] %}
{% if mathtypescases["description"] == 'Absolute value' %}
{{ test_case_absolutevalue(case) }}
{% elif mathtypescases["description"] == 'Exponentiation of a rational number' %}
{{ test_case_exponentiation(case) }}
{% endif %}
{% endfor %}
{% endif %}
{% endfor %}
Co-Authored-By: Corey McCandless <cmccandless@users.noreply.github.com>
cmccandless
suggested changes
Oct 22, 2019
cmccandless
suggested changes
Oct 23, 2019
cmccandless
approved these changes
Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resovles #1975
I've a problem with template and
if/elifconditions. Maybe you can help me whyifconditions only works for 'Arithmetic' description? When you look atrational_numbers_test.py: 74 the tests are only rendered for for that group of cases. Other like 'Absolute value' are omitted.