Skip to content

Resolved Issue #1915 #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yawpitch merged 6 commits into from
Sep 23, 2019
Merged

Resolved Issue #1915 #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d127b80
added jinja2 template for etl auto test generation
alirezaghey Sep 19, 2019
ba335f9
updated etl tests to v2.0.1 canonical data
alirezaghey Sep 19, 2019
c39aa44
minor update to template
alirezaghey Sep 19, 2019
6bbd3a6
Merge branch 'master' into issue-#1915
cmccandless Sep 19, 2019
fa072b4
Update exercises/etl/.meta/template.j2
alirezaghey Sep 19, 2019
08de78d
Merge branch 'master' into issue-#1915
cmccandless Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions exercises/etl/.meta/template.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{%- import "generator_macros.j2" as macros with context -%}
{% macro test_case(case) -%}
{%- set input = case["input"] -%}
def test_{{ case["description"] | to_snake }}(self):
legacy_data = { {% for key, value in case["input"]["legacy"].items() %}
{{key}}: {{value}},{% endfor %} }
data = {{case["expected"]}}
self.assertEqual(
{{ case["property"] | to_snake }}(legacy_data), data
)
{%- endmacro %}
{{ macros.header()}}

class {{ exercise | camel_case }}Test(unittest.TestCase):
{% for supercase in cases %}{% for case in supercase["cases"] -%}
{{ test_case(case) }}
{% endfor %}{% endfor %}


{{ macros.footer() }}
43 changes: 33 additions & 10 deletions exercises/etl/etl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@

from etl import transform

# Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.1

# Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.0

class EtlTest(unittest.TestCase):
def test_a_single_letter(self):
self.assertEqual(transform({1: ['A']}), {'a': 1})
def test_single_letter(self):
legacy_data = {1: ["A"]}
data = {"a": 1}
self.assertEqual(transform(legacy_data), data)

def test_single_score_with_multiple_letters(self):
legacy_data = {1: ["A", "E", "I", "O", "U"]}
Expand All @@ -27,17 +29,38 @@ def test_multiple_scores_with_differing_numbers_of_letters(self):
4: ["F", "H", "V", "W", "Y"],
5: ["K"],
8: ["J", "X"],
10: ["Q", "Z"]
10: ["Q", "Z"],
}
data = {
"a": 1, "b": 3, "c": 3, "d": 2, "e": 1, "f": 4,
"g": 2, "h": 4, "i": 1, "j": 8, "k": 5, "l": 1,
"m": 3, "n": 1, "o": 1, "p": 3, "q": 10, "r": 1,
"s": 1, "t": 1, "u": 1, "v": 4, "w": 4, "x": 8,
"y": 4, "z": 10
"a": 1,
"b": 3,
"c": 3,
"d": 2,
"e": 1,
"f": 4,
"g": 2,
"h": 4,
"i": 1,
"j": 8,
"k": 5,
"l": 1,
"m": 3,
"n": 1,
"o": 1,
"p": 3,
"q": 10,
"r": 1,
"s": 1,
"t": 1,
"u": 1,
"v": 4,
"w": 4,
"x": 8,
"y": 4,
"z": 10,
}
self.assertEqual(transform(legacy_data), data)


if __name__ == '__main__':
if __name__ == "__main__":
unittest.main()