Skip to content

Grep: sync expected test results and input data with problem-specifications#1795

Merged
cmccandless merged 9 commits into
exercism:masterfrom
BethanyG:grep-changes
May 28, 2019
Merged

Grep: sync expected test results and input data with problem-specifications#1795
cmccandless merged 9 commits into
exercism:masterfrom
BethanyG:grep-changes

Conversation

@BethanyG

Copy link
Copy Markdown
Member

Part of #1762

  • Changed the input order of arguments to pattern, flags, files in tests, example.py, and exercise stub to conform with canonical-data.json
  • Changed tests to input an empty string for "no flags" to accommodate the new argument order in example.py and exercise stub.
  • Changed example.py to no longer have a default value for the flags argument.

BethanyG and others added 8 commits April 4, 2019 01:42
merging in changes in order to run configlet
merge in most recent to prep for test editing.
…fications and update example solution."

This reverts commit b4e3777.
Wanted this in it's own branch.
Pulling in most recent exercise changes
merge in changes from main repo
Merge in changes from main repo
@BethanyG BethanyG requested a review from a team as a code owner May 27, 2019 04:23
@cmccandless cmccandless merged commit 09b499c into exercism:master May 28, 2019
@cmccandless

Copy link
Copy Markdown
Contributor

Merged; thanks for working on this!

@BethanyG BethanyG deleted the grep-changes branch May 29, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants