Binary-search: sync expected test inputs with problem-specifications#1783
Merged
Conversation
merging in changes in order to run configlet
merge in most recent to prep for test editing.
…s and update example solution.
…fications and update example solution." This reverts commit b4e3777. Wanted this in it's own branch.
Member
Author
|
Binary-Search changes - #1762 |
cmccandless
approved these changes
May 23, 2019
cmccandless
left a comment
Contributor
There was a problem hiding this comment.
Regarding your comments on whether the use of the name find was safe in Python: it won't shadow because we aren't overriding str.find() specifically, so it's safe.
Contributor
|
Merged; thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed test cases to expect find as the function name to conform with the
cannonical-data.json. Change the example code to have find as the function name.