Skip to content

Knapsack: Implementation based on canonical v1.0.0#1740

Merged
cmccandless merged 10 commits into
exercism:masterfrom
omer-g:knapsack
Apr 4, 2019
Merged

Knapsack: Implementation based on canonical v1.0.0#1740
cmccandless merged 10 commits into
exercism:masterfrom
omer-g:knapsack

Conversation

@omer-g

@omer-g omer-g commented Apr 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add knapsack exercise Python implementation. The example passes the tests manually.
check-exercises.py returns "File with test cases not found" on my machine.
difficulty currently set to 1 in config.json.
Resolves #1736

@omer-g omer-g requested a review from a team as a code owner April 4, 2019 14:30
@omer-g

omer-g commented Apr 4, 2019

Copy link
Copy Markdown
Contributor Author

I'd greatly appreciate some help with the Travis error. Couldn't quite figure out what caused it. Thanks

cmccandless
cmccandless suggested changes Apr 4, 2019
View reviewed changes

@cmccandless cmccandless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got some flake8 violations. You'll need to resolve those before Travis will continue.

Comment thread config.json Outdated
cmccandless
cmccandless suggested changes Apr 4, 2019
View reviewed changes
Comment thread config.json Outdated
Comment thread exercises/knapsack/knapsack_test.py Outdated
Comment thread config.json Outdated
Comment thread config.json Outdated
cmccandless and others added 2 commits April 4, 2019 20:02
@cmccandless @omer-g
Update config.json
a77e1c1 
Co-Authored-By: omer-g <omer-g@users.noreply.github.com>
@cmccandless @omer-g
Update config.json
6394b7c 
Co-Authored-By: omer-g <omer-g@users.noreply.github.com>
@omer-g

omer-g commented Apr 4, 2019

Copy link
Copy Markdown
Contributor Author

It seems that change is not a core exercise so it can't be a prerequisite. This is quite similar to change, so perhaps clock should unlock knapsack as well? Thanks

omer-g added 2 commits April 4, 2019 20:24
@omer-g
knapsack: changes difficulty to 5, adds unlock by
0db35c6 
`clock`, adds topics and removes utility functions in test.
@omer-g
Merge branch 'knapsack' of https://github.com/omer-g/python into knap…
e8d519f 
…sack

Change unlock requirement to `clock`
@cmccandless cmccandless merged commit f34e328 into exercism:master Apr 4, 2019
@cmccandless

cmccandless commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

@omer-g Merged; thanks for working on this!

@omer-g

omer-g commented Apr 4, 2019

Copy link
Copy Markdown
Contributor Author

Thank you for your help and for the merge. When I look in the python track on exercism.io, I see that Knapsack is there but locked to me, even though I completed "Clock". Is it possible that exercises are only unlocked at the moment "Clock" is first completed, and therefore new exercises that are added later aren't unlocked, even if the prerequisite for them has been completed?

@omer-g omer-g deleted the knapsack branch April 4, 2019 18:45
@cmccandless

cmccandless commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

There's a script that has to be run manually when new exercises are added. You should be able to access the new exercise within 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cmccandless cmccandless cmccandless approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omer-g @cmccandless