python/high-scores OOP HINTS#1708
Conversation
OOP hints for High Scores.
|
A quick comment. Less white space. Just my quick initial impression. |
cmccandless
left a comment
There was a problem hiding this comment.
I think the link from official documentation ought to be the first one, but I like the relative ordering of the other two.
And yes, less whitespace would be nice.
|
|
||
|
|
||
|
|
||
| 1) [**Object-Oriented Programming (OOP) in Python 3**](https://realpython.com/python3-object-oriented-programming/) from the Real Python website. Goes over all the definitions and mechanics step by step. Great for the absolute first-timer. |
There was a problem hiding this comment.
Any strong reasoning on ordered vs unordered list for this?
There was a problem hiding this comment.
My original thought was to give a beginner (explains OOP lingo) -->intermediate (uses OOP lingo)-->advanced (talks about language internals) progression.
After talking with @F3PiX and others, I realize that's overkill. Edited to have the docs link, link to class creation, and a link to data structures docs. Also removed/hid OOP mentions. The RP link does have OOP in it, but the link goes to an anchor for creating a class.
Re-ordered and swapped out links.
cmccandless
left a comment
There was a problem hiding this comment.
That's looking a lot better!
|
I like it a lot, @BethanyG |
Co-Authored-By: BethanyG <BethanyG@users.noreply.github.com>
|
Thanks for the eagle eye, @rpottsoh. |
|
@BethanyG if you're done working on this, can you please click "Ready for Review"? |
|
Ah, the extra check I added to Travis was finally triggered. So Travis is failing because |
|
@BethanyG this is almost ready for merge, are you able to re-generate the exercise README? |
|
README re-generated. Apologies for the delay. |
|
@BethanyG merged; thanks for working on this! |
OOP hints for High Scores.