sgf-parsing: update tests to 1.2.0#1615
Conversation
|
Hi! Thanks for the PR! I'm not sure what the intent of these changes is... the added test case is not in the canonical-data, and the added However, there are other changes in the canonical data that have not been reproduced here. Would you like to work on those? If so, please make the appropriate changes, then use magic words to link this PR to issue #1620. |
|
The The test case I added does test a case that is mentioned in the README, but is never tested. I will add the other tests when I will have time. |
@ RE: exercism/python#1615 (comment) This test case is mentioned in the README, but is not yet present in the canonical data. Co-Authored-by: elyashiv <elyashiv@users.noreply.github.com>
|
My apologies. I did not analyze the situation thoroughly; you are correct on both counts.
Interesting that none of the existing tests had an issue with this. What version of Python are you running with?
In that case, it should be added to the canonical data. I have created exercism/problem-specifications#1414 to address this, and have tagged you as a co-author on the commit (since you technically created the test case here). |
I'm running python 2.7.15rc1 on Ubuntu. I'm not an expert on python, but it seems to be a difference between python 2.7 and 3 (https://docs.python.org/3/reference/datamodel.html#object.__ne__ and https://docs.python.org/2.7/reference/datamodel.html#object.__ne__) |
|
Just a couple more things:
|
|
Thanks for the comments! You are right this will close #1620 Is there a way to mark the PR as blocked by a different one? |
Not at this time, no. I'll just have to watch the other PR until it is merged (no problem since it is my PR). |
|
Merged; thanks for working on this! |
close #1620