Skip to content

sgf-parsing: update tests to 1.2.0#1615

Merged
cmccandless merged 7 commits into
exercism:masterfrom
elyashiv:small-fixes-to-sgf
Dec 10, 2018
Merged

sgf-parsing: update tests to 1.2.0#1615
cmccandless merged 7 commits into
exercism:masterfrom
elyashiv:small-fixes-to-sgf

Conversation

@elyashiv

@elyashiv elyashiv commented Dec 4, 2018

Copy link
Copy Markdown
Contributor

close #1620

@cmccandless

Copy link
Copy Markdown
Contributor

Hi! Thanks for the PR!

I'm not sure what the intent of these changes is... the added test case is not in the canonical-data, and the added __ne__ method is never used.

However, there are other changes in the canonical data that have not been reproduced here. Would you like to work on those?

If so, please make the appropriate changes, then use magic words to link this PR to issue #1620.

@elyashiv

elyashiv commented Dec 4, 2018

Copy link
Copy Markdown
Contributor Author

The __ne__ function is actually used in the __eq__ function on some cases. I needed to implement it in order to pass the tests.

The test case I added does test a case that is mentioned in the README, but is never tested.

I will add the other tests when I will have time.

cmccandless added a commit to exercism/problem-specifications that referenced this pull request Dec 4, 2018
@ RE: exercism/python#1615 (comment)

This test case is mentioned in the README, but is not yet present in the canonical data.

Co-Authored-by: elyashiv <elyashiv@users.noreply.github.com>
@cmccandless

Copy link
Copy Markdown
Contributor

My apologies. I did not analyze the situation thoroughly; you are correct on both counts.

The ne function is actually used in the eq function on some cases. I needed to implement it in order to pass the tests.

Interesting that none of the existing tests had an issue with this. What version of Python are you running with?

The test case I added does test a case that is mentioned in the README, but is never tested.

In that case, it should be added to the canonical data. I have created exercism/problem-specifications#1414 to address this, and have tagged you as a co-author on the commit (since you technically created the test case here).

@elyashiv

elyashiv commented Dec 5, 2018

Copy link
Copy Markdown
Contributor Author

Interesting that none of the existing tests had an issue with this. What version of Python are you running with?

I'm running python 2.7.15rc1 on Ubuntu. I'm not an expert on python, but it seems to be a difference between python 2.7 and 3 (https://docs.python.org/3/reference/datamodel.html#object.__ne__ and https://docs.python.org/2.7/reference/datamodel.html#object.__ne__)

@cmccandless

Copy link
Copy Markdown
Contributor

Just a couple more things:

@elyashiv elyashiv changed the title Small fixes to sgf sgf-parsing: update tests to 1.2.0 Dec 6, 2018
@elyashiv

elyashiv commented Dec 6, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for the comments!

You are right this will close #1620

Is there a way to mark the PR as blocked by a different one?

@cmccandless

cmccandless commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

You are right this will close #1620

The magic words must be in the PR description to properly link. I spoke too soon.

Is there a way to mark the PR as blocked by a different one?

Not at this time, no. I'll just have to watch the other PR until it is merged (no problem since it is my PR).

@cmccandless cmccandless self-assigned this Dec 6, 2018
@cmccandless cmccandless merged commit 88c5c61 into exercism:master Dec 10, 2018
@cmccandless

Copy link
Copy Markdown
Contributor

Merged; thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sgf-parsing: update tests to v1.1.0

2 participants