Skip to content

sum-of-multiples: update tests to v1.5.0#1603

Merged
cmccandless merged 10 commits into
exercism:masterfrom
GascaK:issue#1580
Dec 3, 2018
Merged

sum-of-multiples: update tests to v1.5.0#1603
cmccandless merged 10 commits into
exercism:masterfrom
GascaK:issue#1580

Conversation

@GascaK

@GascaK GascaK commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

Fixes #1580

  • Updated 3 test cases to conform to canonical data (reordered list to fit the ascending order convention)
  • Updated example to check for ZeroDivisionError (anything <= 0)

Fixes #1580
* Updated 3 test cases to conform to canonical data (reordered list to fit the ascending order convention)
* Updated example to check for ZeroDivisionError
Small edits to conform to Pep8 standards
Even smaller updates to conform to pep8
Change import to link to correct file
@GascaK

GascaK commented Nov 27, 2018

Copy link
Copy Markdown
Contributor Author

This should also Fix #1567.
Is there a way to check against the continuous integration (Travis CI) before adding an entire commit?

@cmccandless

Copy link
Copy Markdown
Contributor

Travis runs flake8 for style checks. It is available through pip.

Comment thread exercises/sum-of-multiples/example.py Outdated
Comment thread exercises/sum-of-multiples/sum_of_multiples_test.py
Comment thread exercises/sum-of-multiples/example.py Outdated
* Delete blank line
@cmccandless cmccandless merged commit cb49ef8 into exercism:master Dec 3, 2018
@cmccandless

Copy link
Copy Markdown
Contributor

Merged; thanks for working on this!

@GascaK GascaK deleted the issue#1580 branch December 4, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants