Skip to content

reverse-string: add to track#1126

Merged
cmccandless merged 7 commits into
exercism:masterfrom
sjwarner:reverse-string
Dec 31, 2017
Merged

reverse-string: add to track#1126
cmccandless merged 7 commits into
exercism:masterfrom
sjwarner:reverse-string

Conversation

@sjwarner-bp
Copy link
Copy Markdown
Contributor

Add reverse-string to track.

@sjwarner-bp
Copy link
Copy Markdown
Contributor Author

Hi all, I am not too sure why the build is failing - it says

FAILURES: reverse-string (FileNotFound)

Does this mean that I have not added reverse-string to a particular list of exercises somewhere?

Comment thread config.json Outdated
]
},
{
"uuid": "",
Copy link
Copy Markdown
Contributor

@cmccandless cmccandless Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a unique UUID. Use configlet uuid to generate one (see configlet).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, make sure when reading the Travis build output that you look for the earliest error; sometimes these cause the later ones and are the real problem. From this particular failure:

$ ./bin/configlet lint .

-> The exercise 'reverse-string' was found in config.json, but does not have a UUID.

The command "./bin/configlet lint ." exited with 1.

@sjwarner-bp
Copy link
Copy Markdown
Contributor Author

I've added the uuid - silly oversight on my part! The build is still failing with the same error, and I can't seem to see any other errors on the output?

Copy link
Copy Markdown
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename reverse_string_tests.py -> reverse_string_test.py

@cmccandless
Copy link
Copy Markdown
Contributor

Current changes look good. Please remove "[WIP]" from the PR title if you are finished working on this.

@sjwarner-bp sjwarner-bp changed the title [WIP] reverse-string: add to track reverse-string: add to track Dec 8, 2017
@sjwarner-bp
Copy link
Copy Markdown
Contributor Author

Bump! 🙂

@cmccandless cmccandless merged commit 5ab75e4 into exercism:master Dec 31, 2017
@cmccandless
Copy link
Copy Markdown
Contributor

@sjwarner-bp Merged! Thanks for working on this!

@sjwarner-bp sjwarner-bp deleted the reverse-string branch December 31, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants