Add topics for OCR Numbers exercise#971
Conversation
FridaTveit
left a comment
There was a problem hiding this comment.
This looks great @robvanderleek! Thanks for tackling this :) I've left a comment about one of the topics but apart from that it looks ready to merge :)
| "lists", | ||
| "strings", | ||
| "algorithms", | ||
| "parsing" |
There was a problem hiding this comment.
Great suggestions! :) The only one I'm not sure about is algorithms. You could argue that you use an algorithm to solve every exercise but I don't think it would be very useful to add it as a topic to every exercise. Therefore we've been trying only to add it to exercises that require the use of a specific algorithm, e.g. binary-search. So I might be tempted to leave that topic out. What do you think? :)
There was a problem hiding this comment.
Totally agree :-) I puzzled a bit on how to solve this exercise. Eventually ended up using simple string comparisons, but I wondered if others would use a solution based on pattern_matching or perhaps pattern_recognition. Anyway, I've limited the list to 5 topics that are definitely relevant for this exercise.
There was a problem hiding this comment.
@robvanderleek in case you are interested in the way I solved this exercise in the reference solution: https://github.com/exercism/java/tree/master/exercises/ocr-numbers/.meta/src/reference/java. Thanks for the PR!
There was a problem hiding this comment.
Thanks @stkent, glad to contribute! This is my solution: http://exercism.io/submissions/778fc33721c948908cd7b7ba402c7292 pretty similar 😄
FridaTveit
left a comment
There was a problem hiding this comment.
This looks great! Thanks for taking the time to do this @robvanderleek :)
A contribution in the spirit of Hacktoberfest 2017. Hope these are the correct topics, I've touched those programming areas when doing the exercise myself.
Fixes #921
Reviewer Resources:
Track Policies