Fixes #718#746
Merged
Merged
Conversation
Contributor
ilya-khadykin
left a comment
There was a problem hiding this comment.
We should investigate why build has failed
| .map(this::translateWord) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| return String.join(" ", translatedWords); |
Contributor
There was a problem hiding this comment.
It would be even better to get rid of this line:
String.join(" ", translatedWords);with
.collect(Collectors.joining(" "));
Contributor
There was a problem hiding this comment.
Good suggestion @m-a-ge :) So @matthewstyler you could get rid of the last line and change this to
String translate(String sentence) {
return Arrays.stream(sentence.split(" "))
.map(this::translateWord)
.collect(Collectors.joining(" "));
}
If you want to :) It's good as it is though, so don't feel like you have to! :)
|
|
||
| String translate(String sentence) { | ||
| List<String> translatedWords = Arrays.stream(sentence.split(" ")) | ||
| .map(this::translateWord) |
Contributor
There was a problem hiding this comment.
Probably:
.map(PigLatinTranslator::translateWord)
Contributor
There was a problem hiding this comment.
It's an instance method not a static method so it should be this::translateWord :)
Contributor
Author
|
taking a look at the build logs, seems like the PigTranslator isn't the issue: |
Contributor
|
Yeah, that timeout was weird. Restarting the build to see what happens! |
FridaTveit
approved these changes
Aug 20, 2017
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Thanks @matthewstyler, this looks great! :D
There's one further improvement that @m-a-ge suggested that you could address in this PR if you want to :) But if you don't want to then don't worry about it, I can open a new issue for it :)
|
|
||
| String translate(String sentence) { | ||
| List<String> translatedWords = Arrays.stream(sentence.split(" ")) | ||
| .map(this::translateWord) |
Contributor
There was a problem hiding this comment.
It's an instance method not a static method so it should be this::translateWord :)
| .map(this::translateWord) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| return String.join(" ", translatedWords); |
Contributor
There was a problem hiding this comment.
Good suggestion @m-a-ge :) So @matthewstyler you could get rid of the last line and change this to
String translate(String sentence) {
return Arrays.stream(sentence.split(" "))
.map(this::translateWord)
.collect(Collectors.joining(" "));
}
If you want to :) It's good as it is though, so don't feel like you have to! :)
Contributor
Author
|
@m-a-ge & @FridaTveit made that change |
FridaTveit
approved these changes
Aug 21, 2017
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Brilliant! Thank you @matthewstyler! :)
And thanks @m-a-ge for the suggested improvement :) The code looks much neater now thanks to you two :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tighten access modifier and method invocations
Reviewer Resources:
Track Policies