Adds additional test for two-fer exercise#733
Conversation
Smarticles101
left a comment
There was a problem hiding this comment.
Looks good :) Thanks @m-a-ge I'll merge once the build passes
|
Ah this is failing because the example implementation needs to include the code needed to pass the new test |
|
Give me a sec, I'll try to fix it |
|
Per #728 (comment), wouldn't the expected output here be
? |
|
@stkent I think there was a bit of a confusion. Yes, If we are going by the fact that an empty string is a valid name then the expected output you gave would be correct |
|
@stkent, so, you want to see the following cases:
right? |
|
@m-a-ge correct, according to Katrina, that would be correct :) I would still place the empty string test last since it's a boundary case. |
|
in that case, I have to update the code accordingly and clear the history for the last two commits. |
ef53403 to
6065b40
Compare
|
@Smarticles101, thanks! |
This should close #728
I've added additional test (as discussed) somewhat specific to
javatrack and put it in the end of the file (even though this test doesn't present in canonical-data.json for this exercise)Reviewer Resources:
Track Policies