house: add to track#709
Merged
Merged
Conversation
04f348c to
1a95491
Compare
FridaTveit
reviewed
Aug 2, 2017
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
I've left a couple of small comments, but overall it looks great @Smarticles101! :)
| @@ -0,0 +1,51 @@ | |||
| class House { | |||
| static final String[] CHARACTERS = { | |||
Contributor
There was a problem hiding this comment.
This could be private I think?
| "horse and the hound and the horn" | ||
| }; | ||
|
|
||
| static final String[] ACTIONS = { |
Contributor
There was a problem hiding this comment.
This could also be private?
| int startVerse = 1; | ||
| int endVerse = 12; | ||
|
|
||
| assertEquals(expected, house.verses(startVerse, endVerse)); |
Contributor
There was a problem hiding this comment.
Maybe having a method called sing or singWholeSong or something might be useful? So that the caller doesn't have to know that there are 12 verses?
1a95491 to
194b319
Compare
FridaTveit
approved these changes
Aug 7, 2017
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great, thanks @Smarticles101! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Resources:
Track Policies