Skip to content

Adding analyzer feedback for tim-from-marketing concept exercise#2754

Merged
manumafe98 merged 5 commits into
exercism:mainfrom
manumafe98:AddAnalyzerFeedbackToDesignForTimFromMarketing
Mar 31, 2024
Merged

Adding analyzer feedback for tim-from-marketing concept exercise#2754
manumafe98 merged 5 commits into
exercism:mainfrom
manumafe98:AddAnalyzerFeedbackToDesignForTimFromMarketing

Conversation

@manumafe98

Copy link
Copy Markdown
Contributor

pull request

closes #2687

This could be an example that triggers both comments

Reviewer Resources:

Track Policies

@manumafe98 manumafe98 added the x:size/small Small amount of work label Mar 21, 2024
@manumafe98 manumafe98 self-assigned this Mar 21, 2024
@sanderploegsma

Copy link
Copy Markdown
Contributor

The example you linked is an interesting case: clearly the author has enough Java knowledge to understand the Nullable concept, or they wouldn't have chosen to use java.util.Optional. In these cases I'm not sure they will appreciate if the analyzer is being a wise-ass by pointing out that they should use null instead. On the other hand, the goal of this exercise is to practice using null.

I think I would prefer it if we leave an actionable comment that acknowledges that using java.util.Optional is a great way to deal with nullable arguments, but nudges the author to also try to solve the exercise without it. Once #2555 is completed, we could even point out that optionals are covered in a later concept.

What do you think?

@manumafe98

Copy link
Copy Markdown
Contributor Author

I think I would prefer it if we leave an actionable comment that acknowledges that using java.util.Optional is a great way to deal with nullable arguments, but nudges the author to also try to solve the exercise without it. Once #2555 is completed, we could even point out that optionals are covered in a later concept.

What do you think?

Sure, I like that!

Comment thread exercises/concept/tim-from-marketing/.meta/design.md Outdated
Comment thread exercises/concept/tim-from-marketing/.meta/design.md Outdated
@manumafe98 manumafe98 merged commit f8a171c into exercism:main Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tim-from-marketing: describe Analyzer feedback in .meta/design.md

2 participants