Adding analyzer feedback for need for speed concept exercise#2702
Merged
manumafe98 merged 2 commits intoFeb 1, 2024
Merged
Conversation
Also as loops are not a prerequisite of the concept I made some changes to the reference resolution
Contributor
|
I'm reading through the original So I would suggest updating the entire file in this PR to address this. |
Contributor
Author
Oh, good catch, okey I would update the entire file then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
Related issue: #2682
As the exercise does not have loops as a prerequisites, and we do not have a concept that introduces to while loops I made some slight changes to the reference resolution as well
Also I got my inspiration for the go analyzer
Reviewer Resources:
Track Policies