[simple-cipher] Fix outdated reference to SimpleCipherStepThreeTest#2523
Conversation
This test file was removed years ago in exercism#1639, but the instructions still mention it (which caused me, at least, quite a bit of confusion since I thought I had deleted something erroneously). This fixes the documentation to remove the reference to Step Three. If the intent was to never have deleted SimpleCipherStepThreeTest.java in the first place, let me know and I'll amend the PR to that.
sanderploegsma
left a comment
There was a problem hiding this comment.
Thanks for fixing this! One comment to take care of if you would.
This revealed that actually there's a typo in the class name itself. Determining next whether to fix that or leave it be.
sanderploegsma
left a comment
There was a problem hiding this comment.
Great work, thanks for your contribution! 🙏
|
@sanderploegsma I'm worried this might've screwed something up 😅 Since this change went live and I updated my problem on Exercism and resubmitted, the new test files pass locally without a problem but even after 3 submissions spread days apart, the test runner on the site gives me:
I don't think there's anything wrong with my submission so I assume there's some metadata file somewhere we forgot to update to use the new test classes? In general I have no idea how to diagnose issues with the system test runners; I don't even know where those are hosted or if I'm supposed to have access. Can you give me a tip on how to start investigating this? |
|
Hmm that is unfortunate. If the tests run fine locally then perhaps the test runner is having trouble, I suspect with the The Java test runner is open source as well, you can find it here: https://github.com/exercism/java-test-runner. You should be able to run it locally and point it to your local folder containing the exercise files. Maybe that will help understand what is happening behind the scenes. |
pull request
This test file was removed years ago in #1639, but the instructions still mention it (which caused me, at least, quite a bit of confusion since I thought I had deleted something erroneously).
This fixes the documentation to remove the reference to Step Three. If the intent was to never have deleted SimpleCipherStepThreeTest.java in the first place, let me know and I'll amend the PR to that.
Reviewer Resources:
Track Policies