Skip to content

Make Signal class visible in online editor#2191

Merged
andrerfcsantos merged 2 commits into
exercism:mainfrom
artamonovkirill:patch-1
Oct 29, 2022
Merged

Make Signal class visible in online editor#2191
andrerfcsantos merged 2 commits into
exercism:mainfrom
artamonovkirill:patch-1

Conversation

@artamonovkirill
Copy link
Copy Markdown
Contributor

@artamonovkirill artamonovkirill commented Oct 28, 2022

pull request

Closes #2157


Reviewer Resources:

Track Policies

Copy link
Copy Markdown
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Since the Signal.java is not supposed to be modified, we can mark it to appear in the editor as a read-only tab using the files.editor instead of the files.solution key. You can read more about it here or this example for the Go track.

@artamonovkirill
Copy link
Copy Markdown
Contributor Author

artamonovkirill commented Oct 29, 2022

@andrerfcsantos thanks for the feedback, updated

@andrerfcsantos andrerfcsantos merged commit 02fac4d into exercism:main Oct 29, 2022
@artamonovkirill artamonovkirill deleted the patch-1 branch November 16, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:rep/small Small amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secret Handshake exercise should have Signal class/enum visible/editable

2 participants