Fixes issues #2158 and #2165#2160
Merged
Merged
Conversation
joris-boschmans
approved these changes
Aug 29, 2022
There's a typo on the expected value of on of the tests.
andrerfcsantos
approved these changes
Sep 25, 2022
Member
andrerfcsantos
left a comment
There was a problem hiding this comment.
Thanks for this!
- Edited the PR description so the lines mentioning issues read "Fixes <issue_number>" - only this way Github will automatically link the issues and closing them when this PR is fixed.
- When contributing fixes to several exercises/issues, we tend to prefer separate PRs for each one, but since the changes here are small, I'll accept 1 PR for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
Fixes #2158
Fixes #2165
Reviewer Resources:
Track Policies