Skip to content

Updated link broken hyperlink to running the tests#2113

Merged
andrerfcsantos merged 2 commits into
exercism:mainfrom
IAmLuisJ:Fix_installation_broken_link
Jun 9, 2022
Merged

Updated link broken hyperlink to running the tests#2113
andrerfcsantos merged 2 commits into
exercism:mainfrom
IAmLuisJ:Fix_installation_broken_link

Conversation

@IAmLuisJ
Copy link
Copy Markdown
Contributor

pull request

Fixed link on Java track's INSTALLATION.MD for running the tests, was pointing to 404.


Reviewer Resources:

Track Policies

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link
Copy Markdown
Contributor

Closing stale pull request. If you are still working on this, please reopen this pull request.

@github-actions github-actions Bot closed this May 30, 2022
@andrerfcsantos andrerfcsantos reopened this Jun 3, 2022
Copy link
Copy Markdown
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Reopened because this seems like something that's worth fixing.

I found some other instances of this link that are outdated, and some other links that also must be updated/removed. I think we can easily fix them all in this PR, if you agree.

With a quick grep I found other instances of http://exercism.io/languages/java/tests that are also out-of-date and must be updated too:

./docs/INSTALLATION.md:50:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:86:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:123:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:148:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:176:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:210:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".
./docs/INSTALLATION.md:243:To get started, see "[Running the Tests](http://exercism.io/languages/java/tests)".

This link for http://exercism.io/languages/java/installation is also out-of-date and must be updated to https://exercism.org/docs/tracks/java/installation:

./CONTRIBUTING.md:48:   (see [exercism.io: Installing Java](http://exercism.io/languages/java/installation))

There are also some instances of http://exercism.io/languages/java/help. While I don't think there's a natural replacement for this one, probably the best course of action is replace this link by https://gitter.im/exercism/support:

./docs/TESTS.md:46:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./docs/TESTS.md:80:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./docs/TESTS.md:115:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./exercises/shared/.docs/tests.md:46:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./exercises/shared/.docs/tests.md:80:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./exercises/shared/.docs/tests.md:115:If you get stuck, at any point, don't forget to reach out for [help](http://exercism.io/languages/java/help).
./exercises/practice/hello-world/.docs/instructions.append.md:251:http://exercism.io/languages/java/help

There are also references to http://exercism.io/languages/java/todo. For this one, I don't see any replacement, so I suggest removing the whole sentence where it appears:

./CONTRIBUTING.md:173:See [here](http://exercism.io/languages/java/todo) for a list of exercises that have yet to be implemented on the Java track and can therefore be ported to this track.

For reference, the command I ran to get all these cases was:

find . -type f -exec grep --color='auto' 'exercism.io/languages/java' {} /dev/null \;

Would you like to make these changes?

@andrerfcsantos andrerfcsantos mentioned this pull request Jun 3, 2022
@IAmLuisJ
Copy link
Copy Markdown
Contributor Author

IAmLuisJ commented Jun 7, 2022

Yes I'll work on this tonight.

@IAmLuisJ
Copy link
Copy Markdown
Contributor Author

IAmLuisJ commented Jun 8, 2022

All links updated as requested, I'll keep an eye out in case I run into any others. Thank you!

@andrerfcsantos andrerfcsantos added the x:size/small Small amount of work label Jun 9, 2022
Copy link
Copy Markdown
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@andrerfcsantos andrerfcsantos merged commit f1e1dec into exercism:main Jun 9, 2022
@IAmLuisJ IAmLuisJ deleted the Fix_installation_broken_link branch July 5, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants