say: change crlf line endings to lf#2103
Merged
Merged
Conversation
Commit 75fcd7b added a stub implementation to `Say.java` with crlf line endings, and this repo's `.gitattributes` contains: # Force the following filetypes to have unix eols, so Windows does not break them *.* text eol=lf which causes some problems. Resolve by changing line endings back to lf. Before this commit: $ git ls-files --eol | grep crlf i/crlf w/crlf attr/text eol=lf exercises/practice/say/src/main/java/Say.java With this commit: $ git ls-files --eol | grep say i/lf w/lf attr/text eol=lf exercises/practice/say/.docs/instructions.md i/lf w/lf attr/text eol=lf exercises/practice/say/.meta/config.json i/lf w/lf attr/text eol=lf exercises/practice/say/.meta/src/reference/java/Say.java i/lf w/lf attr/text=auto exercises/practice/say/.meta/version i/lf w/lf attr/text eol=lf exercises/practice/say/build.gradle i/lf w/lf attr/text eol=lf exercises/practice/say/src/main/java/Say.java i/lf w/lf attr/text eol=lf exercises/practice/say/src/test/java/SayTest.java Closes: exercism#2102
Contributor
|
This pull request has been automatically marked as |
Contributor
|
um |
andrerfcsantos
approved these changes
Jun 3, 2022
Member
andrerfcsantos
left a comment
There was a problem hiding this comment.
Thanks for this, well spotted.
Also thanks for the clear description of the PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 75fcd7b added a stub implementation to
Say.javawith crlfline endings, and this repo's
.gitattributescontains:java/.gitattributes
Lines 4 to 5 in c2a6465
which causes some problems. Resolve by changing line endings back to lf.
Before this commit:
With this commit:
Closes: #2102
Reviewer Resources:
Track Policies
See e.g.