Changed return type of race to void in TestTrack.java#2012
Merged
Conversation
There's no indication in the examples that TestTrack.race returns anything.... and doesn't make sense given all the other possible return values given the set of other potential return variables all have type int.
Changed return type of race to void
jmrunkle
suggested changes
Sep 11, 2021
Contributor
jmrunkle
left a comment
There was a problem hiding this comment.
Mind also updating the same method in the reference solution? https://github.com/exercism/java/blob/main/exercises/concept/remote-control-competition/.meta/src/reference/java/TestTrack.java
Contributor
|
For the record, I am planning to do a little re-visiting of this exercise to improve the instructions and a few other things to improve this exercise. |
jmrunkle
approved these changes
Sep 15, 2021
kkyb123
pushed a commit
to kkyb123/java
that referenced
this pull request
Sep 24, 2021
* Changed return type of race to void There's no indication in the examples that TestTrack.race returns anything.... and doesn't make sense given all the other possible return values given the set of other potential return variables all have type int. * Change the return type in the exemplar as well Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no indication in the examples that TestTrack.race returns anything.... and doesn't make sense given all the other possible return values given the set of other potential return variables all have type int.