Skip to content

Update Gradle wrapper version#1764

Merged
FridaTveit merged 1 commit into
exercism:masterfrom
stkent:update-gradle
Oct 4, 2019
Merged

Update Gradle wrapper version#1764
FridaTveit merged 1 commit into
exercism:masterfrom
stkent:update-gradle

Conversation

@stkent
Copy link
Copy Markdown
Contributor

@stkent stkent commented Oct 4, 2019

Command invoked:

./gradlew wrapper --gradle-version 5.6.2

No idea if this will pass or not, but let's find out!

Also hi 👋😄 Back for another Hacktoberfest! I opened up a few PRs on the Kotlin repo too if any of the @exercism/java maintainers also have maintainer privileges over there :)

Reviewer Resources:

Track Policies

@stkent
Update Gradle wrapper version
e25bbfa 
Command invoked:

./gradlew wrapper --gradle-version 5.6.2
FridaTveit
FridaTveit approved these changes Oct 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it passed! Thanks @stkent! 😄

@FridaTveit FridaTveit merged commit 40da908 into exercism:master Oct 4, 2019
@lemoncurry
Copy link
Copy Markdown
Contributor

lemoncurry commented Oct 4, 2019

@FridaTveit I think we need to reverse this update or disable the following test that now will always fail with the new gradle version:

ParallelLetterFrequencyTest > multipleThreadsGetUsed FAILED

    java.lang.OutOfMemoryError: Java heap space

        at java.util.Arrays.copyOf(Arrays.java:3332)

        at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)

        at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)

        at java.lang.StringBuilder.append(StringBuilder.java:136)

        at ParallelLetterFrequencyTest.multipleThreadsGetUsed(ParallelLetterFrequencyTest.java:157)```

@stkent stkent deleted the update-gradle branch October 4, 2019 13:13
@FridaTveit
Copy link
Copy Markdown
Contributor

FridaTveit commented Oct 4, 2019

Just put a comment on the other PR @lemoncurry 🙂

@stkent
Copy link
Copy Markdown
Contributor Author

stkent commented Oct 4, 2019

Oof, sorry about that! I guess the full journey test wasn't triggered by the Gradle version update - might be worth adding the gradle.properties file as another trigger for running the full journey.

Also, gross that a Gradle update caused a test to fail - that is not a desirable property!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FridaTveit FridaTveit FridaTveit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stkent @lemoncurry @FridaTveit