list-ops: update test and version file#1730
Conversation
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great! I have only one very minor comment. Thanks for doing this @lemoncurry! 🙂
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great, thanks @lemoncurry! 🙂
| Collections.<Double>emptyList(), | ||
| 2.0, | ||
| (x, y) -> x * y)); | ||
| (x, y) -> x * y) |
There was a problem hiding this comment.
Technically the closing bracket at the end of this line should also be on a new line, to be completely consistent, as that closes the foldLeft which is spread over several lines. The same applies to the other tests using foldLeft and foldRight spread over several lines. It's not very important though, so I'm happy for this to be merged as it is if you prefer 🙂
There was a problem hiding this comment.
Ah yes, I missed it. Now all the cases should be covered.
FridaTveit
left a comment
There was a problem hiding this comment.
Brilliant! Thanks for being so thorough @lemoncurry! 😄
|
Thank you for all your reviews @FridaTveit ! |
closes #1677
Reviewer Resources:
Track Policies