Create script for issue submission (canonical data version changes)#1674
Merged
FridaTveit merged 6 commits intoMay 20, 2019
Merged
Conversation
Script using GitHub API to create new issue when difference between track exercise version file number and canonical data version number is detected.
FridaTveit
reviewed
May 7, 2019
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
This looks great @lemoncurry, thanks for taking the time to do this! 😄
I've left a couple of minor comments and it would be great if we could document how to use this script, perhaps in the contributing guide? 🙂
Contributor
Author
|
I will add some documentation for the script to the contribution guide in the following days. |
FridaTveit
reviewed
May 14, 2019
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great! 😄 I only have two very minor comments, apart from that it looks ready to merge! 🙂
Contributor
Author
|
Thank you @FridaTveit for your review |
FridaTveit
approved these changes
May 20, 2019
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great! Thanks so much for doing this @lemoncurry! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1670
Suggested script using GitHub API to create new issue when difference between track exercise version file number and canonical data version number is detected.
I based the script on the canonical data check script.
I introduced a new label to filter for duplicates,
exercise version update.The script adds a generic title, body and labels.
For example:
Please have a look at the generic texts and fell free to add or remove information/wording (I'm not a native speaker of English, so I would be very glad for corrections 😄). I tried to incorporate parts of texts that have been previously used.
The script may be tested with a private repository. For authentication you need to create a token, which should be kept in a hidden file in your
home directory, and of course should never be committed. Further explanation on what to put into the file is described in the script.Right now, the script only checks for changes in the test version, but not for new exercises.
I'd suggest to add this additional functionality at a later point.
Please let me know if you have further improvements or ideas for the script @exercism/java 😄
Reviewer Resources:
Track Policies