upgrade phone-number to v1.7.0#1637
Merged
Smarticles101 merged 2 commits intoMar 3, 2019
Merged
Conversation
Member
|
Looks like those exception messages have existed for at least 2 years. The canonical data added the error messages after that. I am in favor of changing the exception messages to be more in line with the canonical data. |
Member
|
As an interesting side note, github recently released draft pull requests so you don't have to specify wip anymore. :) |
Contributor
Author
|
@Smarticles101 ok I'll fix them. |
Contributor
Author
|
@Smarticles101 done |
Smarticles101
approved these changes
Mar 3, 2019
Member
Smarticles101
left a comment
There was a problem hiding this comment.
Looks good! Thanks @mirkoperillo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to upgrade the version of phone-number exercise but I have some issues about.
The actual version of exercise in the java track is v1.6.0.
If I compare it with the relative version in canonical-data.json here
exercism/problem-specifications@7290b84?diff=unified
it seems that the exception messages are not aligned to the canonical ones.
Do I have to align them ?
Reviewer Resources:
Track Policies