Update rectangles version file and add test. Closes #1372#1394
Merged
Conversation
FridaTveit
reviewed
Apr 12, 2018
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great, thanks @tendaitt! 🙂 Only a minor indentation thing to be fixed and then it's ready to merge 🙂
| public void testInputWithNoColumnsContainsNoRectangles() { | ||
| String[] inputGrid = new String[]{""}; | ||
|
|
||
| assertEquals(0, rectangleCounter.countRectangles(inputGrid)); |
Contributor
There was a problem hiding this comment.
I think the indentation might be a bit off here? It should be indented with four spaces, same as the other tests 🙂
FridaTveit
approved these changes
Apr 12, 2018
Contributor
FridaTveit
left a comment
There was a problem hiding this comment.
Great, thanks @tendaitt! 😃
hgvanpariya
pushed a commit
to hgvanpariya/java
that referenced
this pull request
May 13, 2018
…ercism#1394) * update version file to 1.1.0 * add test to verify no rectangle when there are no rows * fix test naming to match canonical data * correct spacing for added test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Resources:
Track Policies