Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

TESTS.md: make image links relative#352

Merged
matthewmorgan merged 2 commits into
exercism:masterfrom
morrme:patch-1
May 9, 2017
Merged

TESTS.md: make image links relative#352
matthewmorgan merged 2 commits into
exercism:masterfrom
morrme:patch-1

Conversation

@morrme
Copy link
Copy Markdown
Contributor

@morrme morrme commented May 7, 2017

See #313

@matthewmorgan
Copy link
Copy Markdown
Contributor

@morrme Thanks for doing this work. However, I think the relative pattern that you want in this case is not ./some-file-name.png but rather /some-file-name.png (no dot.)

This is because the browser needs to resolve the file relative to the site root, where the dot syntax would be for resolving in a filesystem.

I don't have the exercism.io webapp installed locally, but I'm pretty confident you will need to make this change. Let me know if you think otherwise. I should be able to find some time to install the app and try your changes locally.

@morrme
Copy link
Copy Markdown
Contributor Author

morrme commented May 9, 2017

When I delete the dot, the image does not render (the left is the current code, the broken link on the right is the result of the change):
nodot

When I add the dot, it returns.

@matthewmorgan
Copy link
Copy Markdown
Contributor

OK, I think I should try to stand up the exercism UI app locally and see what happens. Let me try this and I'll report my findings.

@matthewmorgan
Copy link
Copy Markdown
Contributor

OK, I'm having a bear of a time setting the exercism.io UI app up locally. But, I found a solution that should work for both the local filesystem and the web, EG:

img/SolutionExplorer.png

No dot, no slash. I believe this will work bc of the structure. Shall we try that?

@matthewmorgan matthewmorgan merged commit cbfd514 into exercism:master May 9, 2017
@matthewmorgan
Copy link
Copy Markdown
Contributor

Woohoo! Thanks @morrme ! 🥇

@morrme morrme deleted the patch-1 branch May 9, 2017 23:18
@morrme morrme restored the patch-1 branch May 10, 2017 11:40
@rchavarria
Copy link
Copy Markdown
Contributor

Thanks @morrme for this contribution!!

arthurchipdean pushed a commit to arthurchipdean/xjavascript that referenced this pull request May 24, 2017
* TESTS.md: make image links relative

See #313

* Update TESTS.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants